Skip to content

Support for deleting all keychain items matching a query. #44

Closed
wants to merge 2 commits into from

3 participants

@sanekgusev

I think that -deleteItem: method of SSKeychainQuery is way too restrictive in its precondition checks. According to its description in the header file it is supposed to delete all items matching a query (and TBH this is what I would've expected as well), but in reality it only allows deleting items with specified service and account.
I also feel that method names in SSKeychainQuery are a bit incoherent with each other, but that's probably very subjective.
This pull request is the way I would've done it, but I guess that for the sake of retaining backwards compatibility a simple addition of a -deleteAll: method or the like will suffice.

@soffes
Owner
soffes commented Sep 7, 2013

I'm hesitant to rename fetch:. Do you think there is a better way to do this? + @calebd

@paulmelnikow

How about fetch: and fetchAll:?

@soffes
Owner
soffes commented Sep 7, 2013

@paulmelnikow sounds logical to me.

@soffes
Owner
soffes commented Mar 6, 2014

Can you merge master into your branch so it can merge cleanly?

@soffes
Owner
soffes commented Mar 11, 2016

Closing since this is stale and breaks the public API.

@soffes soffes closed this Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.