diff --git a/CHANGELOG b/CHANGELOG index 6e7372a..868f900 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,5 @@ +* Fix an issue with Effect.ScrollTo that caused Firefox to scroll to the wrong offset in some situations. Closes #10245. [nik.wakelin] + * Fixes an issue with IE ghosting on non-absolute elements. Closes #10423. [Tanrikut, tdd] *V1.8.1* (January 3, 2008) diff --git a/src/effects.js b/src/effects.js index 65fce6e..718a88d 100644 --- a/src/effects.js +++ b/src/effects.js @@ -509,7 +509,7 @@ Effect.ScrollTo = function(element) { var options = arguments[1] || { }, scrollOffsets = document.viewport.getScrollOffsets(), elementOffsets = $(element).cumulativeOffset(), - max = (window.height || document.body.scrollHeight) - document.viewport.getHeight(); + max = document.viewport.getScrollOffsets[0] - document.viewport.getHeight(); if (options.offset) elementOffsets[1] += options.offset; diff --git a/test/functional/effects5b_test.html b/test/functional/effects5b_test.html new file mode 100644 index 0000000..160f29d --- /dev/null +++ b/test/functional/effects5b_test.html @@ -0,0 +1,39 @@ + + +
+