From 9822af257b2b89edfdcd2b42f152d2ab57fc6dcb Mon Sep 17 00:00:00 2001 From: jarek Date: Wed, 17 Apr 2019 23:39:45 +0100 Subject: [PATCH 1/2] Use default retry logic in requests adapter (which is zero). The original commit doesn't explain why retry=3 was introduced in the first place. Before, it was default, zero. Now it seems to conflict with retry decorator used in some call in managers code resulting in 16 retries in total when combined. --- SoftLayer/transports.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/SoftLayer/transports.py b/SoftLayer/transports.py index 56eb14e7c..5db6886bb 100644 --- a/SoftLayer/transports.py +++ b/SoftLayer/transports.py @@ -50,8 +50,7 @@ def get_session(user_agent): 'Content-Type': 'application/json', 'User-Agent': user_agent, }) - retry = Retry(connect=3, backoff_factor=3) - adapter = HTTPAdapter(max_retries=retry) + adapter = HTTPAdapter() client.mount('https://', adapter) return client From aa67c285d79acc48a0f9bad96a292f24999087ab Mon Sep 17 00:00:00 2001 From: jarek Date: Wed, 17 Apr 2019 23:52:18 +0100 Subject: [PATCH 2/2] Remove unused import --- SoftLayer/transports.py | 1 - 1 file changed, 1 deletion(-) diff --git a/SoftLayer/transports.py b/SoftLayer/transports.py index 5db6886bb..298e77f4d 100644 --- a/SoftLayer/transports.py +++ b/SoftLayer/transports.py @@ -13,7 +13,6 @@ import requests from requests.adapters import HTTPAdapter -from urllib3.util.retry import Retry from SoftLayer import consts from SoftLayer import exceptions