Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redox OS support #14

Merged
merged 1 commit into from Aug 8, 2017
Merged

Redox OS support #14

merged 1 commit into from Aug 8, 2017

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Aug 4, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3853e2b on ids1024:redox2 into ** on softprops:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3853e2b on ids1024:redox2 into ** on softprops:master**.

@ids1024
Copy link
Contributor Author

ids1024 commented Aug 7, 2017

@softprops It would be great if you could merge this and softprops/termsize#8.

@softprops softprops merged commit 6f920ae into softprops:master Aug 8, 2017
@softprops
Copy link
Owner

will publish a new version as soon as I get some CI issues sorted out. looks like I've got a bit of travis debt to clean up

@ids1024
Copy link
Contributor Author

ids1024 commented Sep 24, 2017

@softprops Is Travis the only thing preventing a release? I'd like to be able to use this without cargo overrides.

Unit tests are a bit problematic, since you can't necessarily assume whether or not the tests will actually be run in a tty. I'm not sure there's a great solution to that.

@softprops
Copy link
Owner

@ids1024 yea agree I think part of this has to do with travis changing a base default image they use. I'm going to try and clean this up and rely on good faith to publish a new release and see if I can follow up with some flavor of integration style tests. You totally right that these tests are a bit fickle in that they rely on how the runtime runs the tests.

@softprops
Copy link
Owner

done. enjoy!

@ids1024
Copy link
Contributor Author

ids1024 commented Sep 30, 2017

Thanks! And could you also bump termsize? The CI there seems to be failing for similar reasons, i.e. some change in Travis (I guess it used to be attached to a pty, and isn't now, or something like that).

@softprops
Copy link
Owner

That's my guess as well. I'll try to get that done today

@softprops
Copy link
Owner

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants