Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upget build + test compiling in 2018 edition #36
Conversation
softprops
added some commits
Dec 25, 2018
softprops
merged commit 17ea18d
into
master
Dec 26, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
softprops commentedDec 25, 2018
What did you implement:
upgraded to 2018 edition.
Closes: #xxx
How did you verify your change:
cargo check/build/test
What (if anything) would need to be called out in the CHANGELOG for the next release:
mention weird issue with having to use both
use dynomite::Item;anduse dynomite_derive::Item;until I figure out why you need both.