Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: git log --stat, but annotated with codeowner #4

Merged
merged 12 commits into from Feb 10, 2020

Conversation

@FauxFaux
Copy link
Contributor

FauxFaux commented Feb 10, 2020

A partial implementation of git log --stat, which shows the codeowner information.

$ git codeowners log origin/master..
05a4fc chore: do the hokey cokey
 * "Cargo.lock" @ops
 * "Cargo.toml" @ops

e5fe46 feat: Discover current repository
 * "Cargo.lock" @ops
 * "Cargo.toml" @ops
 * "src/main.rs" @softprops

Summary:
 * @softprops: 1 files in 1 commits, including: "src/main.rs" in e5fe46 feat: Discover current repository
 * @ops: 4 files in 2 commits, including: "src/main.rs" in 05a4fc chore: do the hokey cokey

This helps me understand how to batch up commits for reviews by different teams, and whether a commit is inappropriate.


This is probably not ready to merge, but does do something pretty useful as-is. I'm raising this PR just in case I lose interest in taking it any further.

I also rewrote like half the application while getting to this point, making it easier to reuse the existing code. Feel free to cherry-pick out those bits.

@FauxFaux FauxFaux requested a review from softprops as a code owner Feb 10, 2020
@softprops

This comment has been minimized.

Copy link
Owner

softprops commented Feb 10, 2020

@FauxFaux this looks amazing! thanks

@softprops softprops merged commit e9af1a2 into softprops:master Feb 10, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.