Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to create review comments #142

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
2 participants
@phansch
Copy link
Contributor

phansch commented Aug 2, 2018

Got this working much quicker than I thought. Does this look ok?

Note that this only implements Review Comment creation, not review creation. However, review comments don't depend on there being a Review first.

Closes #141

@phansch phansch force-pushed the phansch:review_comments branch from fec62c7 to 0faf6b0 Aug 2, 2018

@softprops

This comment has been minimized.

Copy link
Owner

softprops commented Aug 3, 2018

Looks great! Thanks for the patch

@softprops softprops merged commit a00fd1d into softprops:master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phansch phansch deleted the phansch:review_comments branch Aug 3, 2018

@phansch phansch referenced this pull request Aug 3, 2018

Open

Creating reviews #143

@softprops

This comment has been minimized.

Copy link
Owner

softprops commented Aug 19, 2018

these changes are now published in 0.4.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.