Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chrono Feature #186

Open
schrieveslaach opened this issue Aug 7, 2019 · 3 comments

Comments

@schrieveslaach
Copy link
Contributor

commented Aug 7, 2019

The crate chrono supports parsing of date times in RFC3339 format and the Docker API uses this format e.g. to desribe the start time of a container. I would be vary handy if shiplift would have an optional feature to deserialize these fields as DateTime<FixedOffset>. For example, this PR aixigo/PREvant#13 would benefit from direct support of chrono.

@softprops

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2019

I would be open to a pr to add this feature

@schrieveslaach

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

I can make the PR. I have one question up front. Do you think it should be a feature toggle or do you think chrono should be supported by default?

@softprops

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

I would say a feature toggles that's on by default with the option to turn off would be generally ideal but I'd also be find without a toggle since chrono is pretty ubiquitous in the ecosystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.