Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy_file_into creates sub-directories if required #171

Merged
merged 1 commit into from Jun 1, 2019

Conversation

Projects
None yet
2 participants
@schrieveslaach
Copy link
Contributor

commented May 22, 2019

What did you implement:

The copy_file_into function required that the parent directory of the file to copy exists in the container. This PR ensures that the required path will be created automatically.

How did you verify your change:

Tested with the example examples/containercopyinto.rs and tested with PREvant by this commit.

@softprops

This comment has been minimized.

Copy link
Owner

commented May 23, 2019

Thanks for the patch. Would you mind running rust fmt once and push up the result https://github.com/softprops/shiplift/blob/master/CONTRIBUTING.md#configuring-rustfmt

@schrieveslaach schrieveslaach force-pushed the schrieveslaach:master branch from 660ac7a to ca93f39 May 23, 2019

@schrieveslaach schrieveslaach force-pushed the schrieveslaach:master branch from ca93f39 to 5b77512 May 23, 2019

@schrieveslaach

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

Sure, sorry about that. ✌️

@softprops softprops merged commit 12ec796 into softprops:master Jun 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.