Move error implementation to use thiserror - #242
matthiasbeyer wants to merge 2 commits into
Conversation
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
I will squash if you approve! (The fixup is only the changelog entry). |
|
Thanks for your work on this. however, I tend to err on the side of longer term reductions in maintenance. I鈥檝e been bitten more than one by claiming short term maintenance wins by using an error derivation crate but then as the ecosystem around those change I鈥檒l find myself having to take on hidden maintenance up updating to the new latest and greatest error derivation crate. The cost maintenance of impl errors once and never having to think about them or keeping up with a dependency or error ecosystem trends is actually quite liberating This change might seem like it would solve a maintenance problem but in practice error types tend to change the least compared to other code so it鈥檚 a optimization for a problem I don鈥檛 have today as well as introduces a new maintenance on a dependency I didn鈥檛 have before. |
|
I agree. 馃槃 |
How did you verify your change:
cargo check --all --all-featuresWhat (if anything) would need to be called out in the CHANGELOG for the next release: