Skip to content

Move error implementation to use thiserror - #242

Closed
matthiasbeyer wants to merge 2 commits into
softprops:masterfrom
matthiasbeyer:thiserror
Closed

matthiasbeyer wants to merge 2 commits into
softprops:masterfrom
matthiasbeyer:thiserror

Conversation

@matthiasbeyer

Copy link
Copy Markdown
Collaborator

How did you verify your change:

cargo check --all --all-features

What (if anything) would need to be called out in the CHANGELOG for the next release:

@matthiasbeyer

matthiasbeyer commented Dec 4, 2020 •

Copy link
Copy Markdown
Collaborator Author

I will squash if you approve! (The fixup is only the changelog entry).

@softprops

Copy link
Copy Markdown
Owner

Thanks for your work on this.

however, I tend to err on the side of longer term reductions in maintenance.

I鈥檝e been bitten more than one by claiming short term maintenance wins by using an error derivation crate but then as the ecosystem around those change I鈥檒l find myself having to take on hidden maintenance up updating to the new latest and greatest error derivation crate.

The cost maintenance of impl errors once and never having to think about them or keeping up with a dependency or error ecosystem trends is actually quite liberating

This change might seem like it would solve a maintenance problem but in practice error types tend to change the least compared to other code so it鈥檚 a optimization for a problem I don鈥檛 have today as well as introduces a new maintenance on a dependency I didn鈥檛 have before.

@matthiasbeyer

Copy link
Copy Markdown
Collaborator Author

I agree. 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants