Add Image(s)::save() and deprecate export() #258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elihunter173
force-pushed
the
image-save
branch
from
9043be6 to
231bccd
Compare
elihunter173
force-pushed
the
image-save
branch
from
231bccd to
38b0878
Compare
|
Just realized that I made a typo in one of the return types. Should compile and pass all tests again. |
vv9k
approved these changes
Feb 11, 2021
matthiasbeyer
requested changes
Apr 9, 2021
There was a problem hiding this comment.
Looks good in general.
Just a quick question: We're deprecating functions only on master and delete them before the release in this crate, is that correct? Because I'd imagine that we rather deprecate, release, then remove and make them gone in one release further. So the deprecation would remove them after the 0.8.0 release.
I'm fine either way, just confused why it is done this way and not the other.
| @@ -15,6 +15,7 @@ | |||
| * support for uploading tar to container [#239](https://github.com/softprops/shiplift/pull/239) | |||
| * fix registry authentication to use URL-safe base64 encoding [#245](https://github.com/softprops/shiplift/pull/245) | |||
| * add StopSignal and StopTimeout to ContainerOptionsBuilder [#248](https://github.com/softprops/shiplift/pull/248) | |||
| * add Image(s)::save() and deprecate Image(s)::export() [#257](https://github.com/softprops/shiplift/pull/257) | |||
There was a problem hiding this comment.
I guess this have to be in the changelog for the next one, not for the existing one, right? 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
I renamed
Image::export()toImage::save()and did the same forImagesto make their naming inline with the Go API and the docker CLI.I discovered an old issue #184 that mentions this and I tend to agree that it would be good to use consistent terminology.
Closes: #184
How did you verify your change:
Ran tests locally.
What (if anything) would need to be called out in the CHANGELOG for the next release:
Mention that
Image(s)::export()has been deprecated in favor ofImage(s)::save(). (Already done.)