diff --git a/sdk/src/server-api/sc/networking/clients/LobbyClient.java b/sdk/src/server-api/sc/networking/clients/LobbyClient.java index 91893ae3f..3be2a294e 100644 --- a/sdk/src/server-api/sc/networking/clients/LobbyClient.java +++ b/sdk/src/server-api/sc/networking/clients/LobbyClient.java @@ -116,9 +116,11 @@ private void onGameOver(String roomId, GameResult data) { } private void onGameLeft(String roomId) { + logger.info("Received LeftGameEvent"); for (ILobbyClientListener listener : this.listeners) { listener.onGameLeft(roomId); } + logger.info("Left {}", roomId); } private void onGameJoined(String roomId) { diff --git a/server/src/sc/server/Lobby.kt b/server/src/sc/server/Lobby.kt index 46dab44e8..ebe3d64fb 100644 --- a/server/src/sc/server/Lobby.kt +++ b/server/src/sc/server/Lobby.kt @@ -58,13 +58,13 @@ open class Lobby: GameRoomManager(), IClientListener, Closeable { is JoinPreparedRoomRequest -> try { ReservationManager.redeemReservationCode(source, packet.reservationCode) - } catch(e: RescuableClientException) { + } catch (e: RescuableClientException) { source.send(ProtocolErrorMessage(packet, e.message)) } is JoinRoomRequest -> { val gameRoomMessage = this.joinOrCreateGame(source, packet.gameType) // null is returned if join was unsuccessful - if(gameRoomMessage != null) { + if (gameRoomMessage != null) { clientManager.clients .filter { it.isAdministrator } .forEach { it.send(gameRoomMessage) } @@ -109,14 +109,14 @@ open class Lobby: GameRoomManager(), IClientListener, Closeable { room.step(packet.forced) } is CancelRequest -> { + requireNotNull(packet.roomId) { "Can't cancel a game with roomId null!" } val room = this.findRoom(packet.roomId) room.cancel() - // TODO check whether all clients receive game over message } is PlayerScoreRequest -> { val displayName = packet.displayName val score = getScoreOfPlayer(displayName) - ?: throw IllegalArgumentException("Score for \"$displayName\" could not be found!") + ?: throw IllegalArgumentException("Score for \"$displayName\" could not be found!") logger.debug("Sending score of player \"{}\"", displayName) source.send(PlayerScoreResponse(score)) }