fix: refactor C++ JSI promises #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubGonera
force-pushed
the
@jakubgonera/style-transfer-exceptions
branch
from
20ba72c to
452ede5
Compare
JakubGonera
force-pushed
the
@jakubgonera/promise-refactor
branch
from
d86d00c to
891d632
Compare
JakubGonera
force-pushed
the
@jakubgonera/style-transfer-exceptions
branch
from
d72b399 to
1ae1b35
Compare
mkopcins
approved these changes
May 20, 2025
Base automatically changed from
@jakubgonera/style-transfer-exceptions
to
@jakubgonera/cpp
May 20, 2025 13:48
JakubGonera
force-pushed
the
@jakubgonera/promise-refactor
branch
from
891d632 to
3ad9678
Compare
JakubGonera
added a commit
that referenced
this pull request
May 28, 2025
## Description In the C++ code we need some interface between raw JSI and our logic using JS promises. The current implementation uses too many nested lambdas, as well requires `std::function` bindings to each lambda. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Related issues #255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the C++ code we need some interface between raw JSI and our logic using JS promises. The current implementation uses too many nested lambdas, as well requires
std::functionbindings to each lambda.Type of change
Tested on
Related issues
#255