From 513ff6ffff3753555900c08b287a6d446a4d2474 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Osadnik?= Date: Wed, 8 Jan 2020 14:12:44 -0500 Subject: [PATCH] Fix procs handling by removing parentNode check (#541) In procs it happens, that parent might not be present and this should not be breaking --- .../main/java/com/swmansion/reanimated/NodesManager.java | 8 -------- ios/REANodesManager.m | 2 -- 2 files changed, 10 deletions(-) diff --git a/android/src/main/java/com/swmansion/reanimated/NodesManager.java b/android/src/main/java/com/swmansion/reanimated/NodesManager.java index 600f5c1943a..401247a01af 100644 --- a/android/src/main/java/com/swmansion/reanimated/NodesManager.java +++ b/android/src/main/java/com/swmansion/reanimated/NodesManager.java @@ -285,10 +285,6 @@ public void dropNode(int tag) { public void connectNodes(int parentID, int childID) { Node parentNode = mAnimatedNodes.get(parentID); - if (parentNode == null) { - throw new JSApplicationIllegalArgumentException("Animated node with ID " + parentID + - " does not exists"); - } Node childNode = mAnimatedNodes.get(childID); if (childNode == null) { throw new JSApplicationIllegalArgumentException("Animated node with ID " + childID + @@ -299,10 +295,6 @@ public void connectNodes(int parentID, int childID) { public void disconnectNodes(int parentID, int childID) { Node parentNode = mAnimatedNodes.get(parentID); - if (parentNode == null) { - throw new JSApplicationIllegalArgumentException("Animated node with ID " + parentID + - " does not exists"); - } Node childNode = mAnimatedNodes.get(childID); if (childNode == null) { throw new JSApplicationIllegalArgumentException("Animated node with ID " + childID + diff --git a/ios/REANodesManager.m b/ios/REANodesManager.m index 082595e5f94..1f263c1f942 100644 --- a/ios/REANodesManager.m +++ b/ios/REANodesManager.m @@ -270,7 +270,6 @@ - (void)connectNodes:(nonnull NSNumber *)parentID childID:(nonnull REANodeID)chi REANode *parentNode = _nodes[parentID]; REANode *childNode = _nodes[childID]; - RCTAssertParam(parentNode); RCTAssertParam(childNode); [parentNode addChild:childNode]; @@ -284,7 +283,6 @@ - (void)disconnectNodes:(REANodeID)parentID childID:(REANodeID)childID REANode *parentNode = _nodes[parentID]; REANode *childNode = _nodes[childID]; - RCTAssertParam(parentNode); RCTAssertParam(childNode); [parentNode removeChild:childNode];