Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opacity from native props list #3139

merged 1 commit into from Apr 7, 2022


Copy link

@tomekzaw tomekzaw commented Apr 5, 2022


Currently, opacity prop is listed both in UI_THREAD_PROPS_WHITELIST and NATIVE_THREAD_PROPS_WHITELIST. However, when splitting props into three groups (namely: UI props, native props and JS props), we always search in the UI props set first, so effectively opacity is always animated like a UI prop (which is the expected behaviour). Nevertheless, we would like to avoid confusion by keeping these two sets disjoint, so this PR removes opacity from NATIVE_THREAD_PROPS_WHITELIST.


  • Removed opacity from native props list

Test code and steps to reproduce

  1. Launch Example app
  2. Open Olympic animation demo
  3. See if opacity is properly animated


  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

@tomekzaw tomekzaw requested a review from piaskowyk April 5, 2022 21:07
Copy link

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@piaskowyk piaskowyk merged commit 1a292f7 into main Apr 7, 2022
1 check passed
@piaskowyk piaskowyk deleted the @tomekzaw/remove-opacity-from-native-props branch April 7, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants