Remove opacity
from native props list
#3139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Currently,
opacity
prop is listed both inUI_THREAD_PROPS_WHITELIST
andNATIVE_THREAD_PROPS_WHITELIST
. However, when splitting props into three groups (namely: UI props, native props and JS props), we always search in the UI props set first, so effectivelyopacity
is always animated like a UI prop (which is the expected behaviour). Nevertheless, we would like to avoid confusion by keeping these two sets disjoint, so this PR removesopacity
fromNATIVE_THREAD_PROPS_WHITELIST
.Changes
opacity
from native props listTest code and steps to reproduce
Checklist