Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android crash when reloading JSC runtime #3469

merged 1 commit into from Aug 16, 2022


Copy link


Fixes #3351.


Test code and steps to reproduce


  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

@tomekzaw tomekzaw marked this pull request as draft August 12, 2022 12:43
Copy link

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it in the expo go and seems to be working fine 🔥

@tomekzaw tomekzaw marked this pull request as ready for review August 16, 2022 08:13
Copy link
Member Author

@piaskowyk Can we get this fix in 2.10 release?

@piaskowyk piaskowyk merged commit c47276a into main Aug 16, 2022
3 checks passed
@piaskowyk piaskowyk deleted the @tomekzaw/fix-android-crash-jsc-reload branch August 16, 2022 08:34
piaskowyk pushed a commit that referenced this pull request Aug 17, 2022
Copy link

Slapbox commented Sep 20, 2022

Was this incorporated into 2.10.0? I think yes? But I don't see if in the changelog or in the compare feature: 2.9.1...2.10.0

This crash is killing us.

Copy link
Member Author

tomekzaw commented Sep 21, 2022

Hey, it looks like this was released only in 3.0.0-rc.2. @piaskowyk Can we get this cherry-picked for 2.11?

This PR was cherry-picked for 2.10.0 so the crash should be already fixed:

Copy link

Slapbox commented Sep 21, 2022

Confirming the crash appears to be resolved now.

kyunkakata added a commit to kyunkakata/react-native-reanimated that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Crash on app reload on Android in reanimated::NativeProxy::~NativeProxy
4 participants