Deprecate wait_for_accept parameter
#1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomek0123456789
changed the base branch from
development
to
drknzz/starknet-0.12.0
tomek0123456789
changed the title
wait_for_accept parameter wait_for_accept parameter
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## drknzz/starknet-0.12.0 #1102 +/- ##
===========================================================
+ Coverage 87.45% 97.55% +10.09%
===========================================================
Files 92 92
Lines 4258 4260 +2
===========================================================
+ Hits 3724 4156 +432
+ Misses 534 104 -430
☔ View full report in Codecov by Sentry. |
drknzz
reviewed
Jul 11, 2023
| first_run = True | ||
| try: | ||
| while True: | ||
| result = await self.get_transaction_receipt(tx_hash=tx_hash) |
Contributor
There was a problem hiding this comment.
We would probably need to catch failed receipt fetch, and retry
drknzz
reviewed
Jul 12, 2023
| ------------ | ||
| .. currentmodule:: starknet_py.net.client | ||
|
|
||
| 1. `wait_for_accept` parameter in :meth:`Client.wait_for_tx` and :meth:`SentTransaction.wait_for_acceptance` have been deprecated. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. `wait_for_accept` parameter in :meth:`Client.wait_for_tx` and :meth:`SentTransaction.wait_for_acceptance` have been deprecated. | |
| 1. `wait_for_accept` parameter in :meth:`Client.wait_for_tx` and :meth:`SentTransaction.wait_for_acceptance` has been deprecated. |
…al' into tomek/wait-for-transaction-removal
drknzz
approved these changes
Jul 12, 2023
drknzz
added a commit
that referenced
this pull request
Jul 13, 2023
* Remove PENDING tx status * Update .gitignore * Use Cairo v2.0.0-rc5 * Use cairo-lang 0.12.0a0 * Add compile_contracts_v2.sh * Add new syntax contracts * Add complex abi v1 contract * Bump devnet * Add more new syntax contracts * Add more v2 syntax contracts * Remove unused contract * Update tests * Use devnet 0.5.5a0 * Use devnet 0.5.5 * Use Cairo v2.0.0 * Update contracts to Cairo v2.0.0 * Update tests * Extend hello2.cairo * Format * Add abi_types.cairo * V1_DIR -> V2_DIR * Shape + Schemas * AbiParserV2 * Lint, Format, Typecheck * Compile v1.1.0 contracts on CI * Remove unused variables * Remove cache-rust * Fix typing * Update checks.yml * Run tests on v1 and v2 contracts * Export manifest path * Update checks.yml * Update checks.yml * Add compiled contracts * Download artifacts * Clean up * Deprecate `wait_for_accept` parameter in `Client.wait_for_tx` (#1102) * deprecated wait_for_transaction parameter * added poe precommit task * added note in migration guide * migration guide fix * logic change * logic change * formatting * added retries below 0 check * typos * fixed logic * docstring fix * deprecated wait_for_transaction parameter * added poe precommit task * added note in migration guide * migration guide fix * logic change * logic change * formatting * added retries below 0 check * typos * fixed logic * docstring fix * Handle no status in RPC --------- Co-authored-by: drknzz <kamil.jankowski.x@gmail.com> * Fix v2 nested types * Remove unused _get_struct * Remove wait_for_tx NOT_RECEIVED tests * Fix nested types v2 tests * Fix nested types v1 * Fix template structs * Update migration guide --------- Co-authored-by: Tomasz Miśkowicz <tomasz.miskowicz@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced changes
wait_for_acceptparameter inClient.wait_for_txandContract.wait_for_acceptancemethods is now deprecatedretriesparameter