Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models for Web UI #52

Merged
merged 7 commits into from Feb 4, 2020
Merged

Models for Web UI #52

merged 7 commits into from Feb 4, 2020

Conversation

@vova-beloded
Copy link
Collaborator

vova-beloded commented Jan 31, 2020

Fixes #8

Checklist

  • Documented

  • Unit tested

vova.beloded vova.beloded
@vova-beloded vova-beloded marked this pull request as ready for review Jan 31, 2020
vova.beloded added 3 commits Jan 31, 2020
Future<List<Build>> call(ProjectIdParam param) {
return _repository.getProjectBuilds(param.projectId);
}
}

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Feb 1, 2020

Contributor

Let's add newlines to the end of the files. Sometimes your IDE will have a setting to handle this automatically.

image

);
});

test("Properly loads the build points", () async {

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Feb 1, 2020

Contributor

These tests are awesome!

vova.beloded vova.beloded
Copy link
Collaborator

illia-romanenko left a comment

Great job so far Vova! Please review small comments & discussed approach for BL in Use Cases.

Copy link
Collaborator

illia-romanenko left a comment

Great job! Some small things and should be good to go.

@@ -0,0 +1,10 @@
/// Represents the [numberOfBuilds] during some [date].

This comment has been minimized.

Copy link
@illia-romanenko

illia-romanenko Feb 3, 2020

Collaborator
Suggested change
/// Represents the [numberOfBuilds] during some [date].
/// Represents the [numberOfBuilds] on specified [date].
@@ -10,4 +11,4 @@ class Coverage extends Equatable {

@override
List<Object> get props => [percent];
}
}

This comment has been minimized.

Copy link
@illia-romanenko

illia-romanenko Feb 3, 2020

Collaborator
Suggested change
}
}
});
}

class MetricsRepositoryStabImpl implements MetricsRepository {

This comment has been minimized.

Copy link
@illia-romanenko

illia-romanenko Feb 3, 2020

Collaborator
Suggested change
class MetricsRepositoryStabImpl implements MetricsRepository {
class MetricsRepositoryStubImpl implements MetricsRepository {
Copy link
Collaborator

illia-romanenko left a comment

Well done!

@vova-beloded vova-beloded merged commit 75123f1 into master Feb 4, 2020
1 check passed
1 check passed
Bitrise Summary
Details
@vova-beloded vova-beloded deleted the models_for_web_ui branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.