Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdopkg >= 0.43 appends # patches_base even when not needed #122

Closed
yac opened this issue Jun 13, 2017 · 5 comments
Closed

rdopkg >= 0.43 appends # patches_base even when not needed #122

yac opened this issue Jun 13, 2017 · 5 comments
Assignees

Comments

@yac
Copy link
Contributor

yac commented Jun 13, 2017

This can be seen for example by running rdopkg new-verision 0.44 in it's own master:

 Source0:          https://pypi.python.org/packages/source/r/%{name}/%{name}-%{version}.tar.gz
 
+#
+# patches_base=0.44
+#
+
 BuildArch:        noarch

patches_base is uneeded.

@yac
Copy link
Contributor Author

yac commented Jun 13, 2017

This was introduced by b328265 pre 0.43.

@yac yac self-assigned this Jun 13, 2017
@yac
Copy link
Contributor Author

yac commented Jun 14, 2017

No more hax. Correct solution to this is a maintainable unit tested magic comments parser.

@yac
Copy link
Contributor Author

yac commented Jun 19, 2017

As a first step, unit tests are needed to cover wanted behavior, but that is very hard with current unit tests and thus first #123 must be solved.

@yac
Copy link
Contributor Author

yac commented Jul 13, 2017

This actually happens only when I test on rdopkg distgit but not on the testing one in https://softwarefactory-project.io/r/#/c/8679/ so it must be a special case. Need to find out what triggers this.

@yac
Copy link
Contributor Author

yac commented Jul 13, 2017

Hahaha, rdopkg distgit was probably the only one to ever get hit by this bug because it has filter_patches string in the changelog :D Here is a fix of a hack before we get proper fix for this whole patches_* comments mess: https://softwarefactory-project.io/r/#/c/8930/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant