This repository was archived by the owner on Mar 27, 2023. It is now read-only.
Delegate "info" calls to wrapped Reporter #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kciesielski
commented
Mar 15, 2016
kciesielski
commented
- This fixes Clippy 0.2.2 breaks Quill #8
Member
Author
|
Not sure why the build fails. It says |
| // cannot delegate to info0 as it's protected, hence special-casing on the possible severity values | ||
| if (severity == INFO) { | ||
| info(pos, msg, force) | ||
| r.info(pos, msg, force) |
Member
There was a problem hiding this comment.
shouldn't we do the same for warning, error?
Member
Author
There was a problem hiding this comment.
We do it for warning:
override def warning(pos: Position, msg: String) =
r.warning(pos, msg)and for error
override def error(pos: Position, msg: String) =
r.error(pos, handleError(pos, msg))similarly for echo()
Member
There was a problem hiding this comment.
true, it just didn't look this way with the code folded :)
adamw
added a commit
that referenced
this pull request
Mar 15, 2016
Delegate "info" calls to wrapped Reporter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.