Add autopilot support #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozek1997
reviewed
Apr 24, 2023
Collaborator
rozek1997
left a comment
rozek1997
left a comment
There was a problem hiding this comment.
LGTM 👍 , minor comments regarding node pool configuration
| remove_default_node_pool = !var.enable_autopilot ? true : null | ||
| enable_autopilot = var.enable_autopilot | ||
| initial_node_count = 1 | ||
| node_config { |
Collaborator
There was a problem hiding this comment.
I think that needs to be conditional when enable_autopilot is true by using dynamic mapping. In other case it will probably throw an error during cluster creation.
gkocur
force-pushed
the
feat/autopilot-support
branch
from
3622efa to
798626c
Compare
gkocur
force-pushed
the
feat/autopilot-support
branch
2 times, most recently
from
91488d9 to
dfc74bb
Compare
gkocur
force-pushed
the
feat/autopilot-support
branch
from
dcf65ea to
14159dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.