Unify subcomponent handling and call MNA methods through the parent #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
JTS22
force-pushed
the
subcomponents
branch
2 times, most recently
from
3b1bd1b
to
362308c
Compare
This was referenced Nov 28, 2022
Merged
dinkelbachjan
force-pushed
the
subcomponents
branch
from
caf2929
to
fc46c4d
Compare
Signed-off-by: Jonas Schroeder <jonas.schroeder1@rwth-aachen.de>
dinkelbachjan
force-pushed
the
subcomponents
branch
from
fc46c4d
to
98e4fea
Compare
|
Kudos, SonarCloud Quality Gate passed! |
m-mirz
approved these changes
Jan 8, 2023
m-mirz
added a commit
that referenced
this pull request
Jan 9, 2023
Resolves many of the FIXME comments spread throughout the code. The main changes are: - Removal of variables that are never used, only read, or only written to - Renaming the `attribute<T>` method in `AttributeList` to `attributeTyped<T>` to avoid overlap with the method returning an `AttributeBase::Ptr` - Adding a constructor taking the attribute map to component base classes for attribute initialization Based on #141 Related to #132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all components that declare some kind of subcomponents, this PR unifies the handling of these subcomponents such that:
mSubComponentsmnaPreStep,mnaPostStep...) are called directly in the same-named parent method and not through custom tasksmSubComponentsBased on #140
Related to #131