New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use argparse instead of getopt #2260

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
4 participants
@lilydjwg
Contributor

lilydjwg commented Aug 12, 2017

see also https://github.com/soimort/you-get/issues/1181.

功能上应该完全没有改变,输出上,呃,它变长了……好处是选项的定义更加声明化,不会忘记改帮助信息了的。也添加了几个互斥组。

需要的话,我可以进一步优化。

@soimort-bot

This comment has been minimized.

Show comment
Hide comment
@soimort-bot

soimort-bot Aug 12, 2017

Collaborator

Hello @lilydjwg,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

Collaborator

soimort-bot commented Aug 12, 2017

Hello @lilydjwg,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

@soimort

This comment has been minimized.

Show comment
Hide comment
@soimort

soimort Sep 11, 2017

Owner

Looks good. Thanks!

Owner

soimort commented Sep 11, 2017

Looks good. Thanks!

@soimort soimort merged commit bcd8d74 into soimort:develop Sep 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lilydjwg lilydjwg deleted the lilydjwg:argparse branch Sep 11, 2017

@ayanamist

This comment has been minimized.

Show comment
Hide comment
@ayanamist

ayanamist Sep 12, 2017

Contributor

socks_proxy is not defined here, i think it should be proxy in function arguments.

Contributor

ayanamist commented on src/you_get/common.py in bcd8d74 Sep 12, 2017

socks_proxy is not defined here, i think it should be proxy in function arguments.

This comment has been minimized.

Show comment
Hide comment
@lilydjwg

lilydjwg Sep 12, 2017

Contributor

Yes, I'll fix that.

Contributor

lilydjwg replied Sep 12, 2017

Yes, I'll fix that.

@lilydjwg lilydjwg referenced this pull request Sep 12, 2017

Merged

fix wrong local name #2346

download_main(
download, download_playlist,
URLs, args.playlist,
stream_id=stream_id, output_dir=args.output_dir, merge=not args.no_merge,

This comment has been minimized.

@soimort

soimort Sep 12, 2017

Owner

Be careful not to duplicate the keyword argument stream_id here. (it's already in extra)

@soimort

soimort Sep 12, 2017

Owner

Be careful not to duplicate the keyword argument stream_id here. (it's already in extra)

This comment has been minimized.

@lilydjwg

lilydjwg Sep 12, 2017

Contributor

Oh yes, thanks.

@lilydjwg

lilydjwg Sep 12, 2017

Contributor

Oh yes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment