New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert argparse, back to getopt #2358

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@lilydjwg
Contributor

lilydjwg commented Sep 14, 2017

Because "moving from gnu_getopt to argparse brings more problems than it solves, if it really solves any". It contains "grammar errors brought with by a new patch", doesn't fix "something defected exsited in the old code". "there is no reason to blame the old code."

What's more, "argparse is much more complex with a lengthy document", it makes you-get pythonic, but we need to make "Those who only know js or as3 can contribute because you-get is not pythonic".

"This patch is premature and personal taste."

If you read the help again and again to find a flag that you know you-get has but failed, you can just read the source code. And if you're familiar with "js or as3", probably you can contribute to fix it. "keeping description up-to-date" isn't a tough task after all.

This reverts commit bcd8d74.

This commit closes #2351, #2355 and probably #2145 too.

Revert argparse, back to getopt
Because "moving from gnu_getopt to argparse brings more problems than it
solves, if it really solves any". It contains "grammar errors brought with
by a new patch", doesn't fix "something defected exsited in the old
code". "there is no reason to blame the old code."

What's more, "argparse is much more complex with a lengthy document", it
makes you-get pythonic, but we need to make "Those who only know js or
as3 can contribute because you-get is not pythonic".

"This patch is premature and personal taste."

If you read the help again and again to find a flag that you know
you-get has but failed, you can just read the source code. And if you're
familiar with "js or as3", probably you can contribute to fix it.
"keeping description up-to-date" isn't a tough task after all.

This reverts commit bcd8d74.

This commit closes #2351, #2355 and probably #2145 too.
@soimort-bot

This comment has been minimized.

Show comment
Hide comment
@soimort-bot

soimort-bot Sep 14, 2017

Collaborator

Hello @lilydjwg,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

Collaborator

soimort-bot commented Sep 14, 2017

Hello @lilydjwg,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

@lilydjwg

This comment has been minimized.

Show comment
Hide comment
@lilydjwg

lilydjwg Sep 14, 2017

Contributor

BTW, I'm going to delete several patches that haven't made their path to be pull requests because of the reason listed above.

Contributor

lilydjwg commented Sep 14, 2017

BTW, I'm going to delete several patches that haven't made their path to be pull requests because of the reason listed above.

@soimort soimort closed this Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment