IKeyOptions interface fix #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: LoveSeat/Support/KeyOptions.cs
…with multiple parameters, therefore adding multiple (Start/End)Key params didn't work. This interface was also moved to Interfaces folder.
|
Good call. Yeah I forgot to do that, sorry about that. Thanks for the commit! Glad to have someone checking behind me. What do you think of the new approach for Keys? |
|
It's great, I'm already using it. |
|
BTW, can I add MIT license file to the root of the project? |
|
That would be great. I've been meaning to put the license in comments at the top of all the source files but I don't have a utility to do that. Do you have such a thing? If you do that would be huge as well. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IKeyOptions didn't have Add method declaration with multiple params, therefore it didn't work using this option. I also moved this interface to corresponding folder.