New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKeyOptions interface fix #3

Merged
4 commits merged into from Dec 16, 2010

Conversation

Projects
None yet
2 participants
@yojimbo87
Contributor

yojimbo87 commented Dec 16, 2010

IKeyOptions didn't have Add method declaration with multiple params, therefore it didn't work using this option. I also moved this interface to corresponding folder.

yojimbo87 added some commits Dec 16, 2010

Merge branch 'master' of git://github.com/soitgoes/LoveSeat
Conflicts:
	LoveSeat/Support/KeyOptions.cs
Fixed IkeyOptions interface which didn't have Add method declaration …
…with multiple parameters, therefore adding multiple (Start/End)Key params didn't work. This interface was also moved to Interfaces folder.
@soitgoes

This comment has been minimized.

Show comment
Hide comment
@soitgoes

soitgoes Dec 16, 2010

Owner

Good call. Yeah I forgot to do that, sorry about that. Thanks for the commit! Glad to have someone checking behind me. What do you think of the new approach for Keys?

Owner

soitgoes commented Dec 16, 2010

Good call. Yeah I forgot to do that, sorry about that. Thanks for the commit! Glad to have someone checking behind me. What do you think of the new approach for Keys?

@yojimbo87

This comment has been minimized.

Show comment
Hide comment
@yojimbo87

yojimbo87 Dec 16, 2010

Contributor

It's great, I'm already using it.

Contributor

yojimbo87 commented Dec 16, 2010

It's great, I'm already using it.

@yojimbo87

This comment has been minimized.

Show comment
Hide comment
@yojimbo87

yojimbo87 Dec 16, 2010

Contributor

BTW, can I add MIT license file to the root of the project?

Contributor

yojimbo87 commented Dec 16, 2010

BTW, can I add MIT license file to the root of the project?

@soitgoes

This comment has been minimized.

Show comment
Hide comment
@soitgoes

soitgoes Dec 16, 2010

Owner

That would be great. I've been meaning to put the license in comments at the top of all the source files but I don't have a utility to do that. Do you have such a thing? If you do that would be huge as well.

Owner

soitgoes commented Dec 16, 2010

That would be great. I've been meaning to put the license in comments at the top of all the source files but I don't have a utility to do that. Do you have such a thing? If you do that would be huge as well.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment