Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure custom headers for webhooks #226

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Ability to configure custom headers for webhooks #226

merged 3 commits into from
Dec 30, 2021

Conversation

stayallive
Copy link
Collaborator

Title is pretty descriptive here I think :)

Also removed the enableClientMessages in the webhook tests where client events are not used to prevent confusion.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #226 (6d52b02) into master (23ec401) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 6d52b02 differs from pull request most recent head 1c9e894. Consider uploading reports for the commit 1c9e894 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   84.64%   84.81%   +0.17%     
==========================================
  Files          40       40              
  Lines        1830     1831       +1     
  Branches      323      324       +1     
==========================================
+ Hits         1549     1553       +4     
+ Misses        272      269       -3     
  Partials        9        9              
Impacted Files Coverage Δ
src/app.ts 90.19% <ø> (ø)
src/webhook-sender.ts 85.00% <100.00%> (+0.18%) ⬆️
src/rate-limiters/cluster-rate-limiter.ts 96.87% <0.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ec401...1c9e894. Read the comment docs.

@rennokki rennokki merged commit 5aa7022 into soketi:master Dec 30, 2021
@stayallive stayallive deleted the feature/webhook-custom-headers branch December 30, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants