Use return value of wallet.signTransaction#1527
Merged
paul-schaaf merged 4 commits intomasterfrom Mar 20, 2022
unknown repository
Merged
Use return value of wallet.signTransaction#1527paul-schaaf merged 4 commits intomasterfrom unknown repository
paul-schaaf merged 4 commits intomasterfrom
unknown repository
Conversation
Contributor
|
thank you! |
Author
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #1529 by changing the way wallet signing is handled i.e it uses return value as an up-to-date transaction representation rather than hoping old object will get mutated by wallet.