Skip to content

remove avm use prompt, and insist on user installing a version if it's not yet installed#1565

Merged
paul-schaaf merged 2 commits intosolana-foundation:masterfrom
SvenDowideit:avm-install-before-use
Mar 17, 2022
Merged

remove avm use prompt, and insist on user installing a version if it's not yet installed#1565
paul-schaaf merged 2 commits intosolana-foundation:masterfrom
SvenDowideit:avm-install-before-use

Conversation

@SvenDowideit
Copy link
Copy Markdown
Contributor

@SvenDowideit SvenDowideit commented Mar 7, 2022

Closes #1562

replaces #1558

Comment thread avm/src/lib.rs Outdated
@SvenDowideit SvenDowideit force-pushed the avm-install-before-use branch from 2d37597 to 47dbeed Compare March 7, 2022 02:39
@paul-schaaf
Copy link
Copy Markdown
Contributor

LGTM. pls add a line to the breaking section of the changelog

@SvenDowideit SvenDowideit force-pushed the avm-install-before-use branch from 47dbeed to ed2b7ad Compare March 13, 2022 04:35
@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented Mar 13, 2022

root@4e25ea78ccf3:/# avm use 0.22.1
Error: Could not parse version file: unexpected end of input while parsing major version number
root@4e25ea78ccf3:/# avm use latest
Error: Could not parse version file: unexpected end of input while parsing major version number

I guess there's something else i need to learn about in the code :)

(oh, this happens when there's no version installed, and the code currently tries and fails to parse nothing)

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

ok, added a fix for the initial condition

Comment thread avm/src/lib.rs Outdated
@SvenDowideit SvenDowideit force-pushed the avm-install-before-use branch from 23fa392 to 9bfa480 Compare March 17, 2022 01:58
@paul-schaaf paul-schaaf merged commit e567e14 into solana-foundation:master Mar 17, 2022
@paul-schaaf
Copy link
Copy Markdown
Contributor

thank you!

@SvenDowideit SvenDowideit deleted the avm-install-before-use branch March 18, 2022 00:00
@SvenDowideit
Copy link
Copy Markdown
Contributor Author

oops, sorry for the dependency :)

SvenDowideit added a commit to SvenDowideit/anchor-book that referenced this pull request Mar 18, 2022
paul-schaaf pushed a commit to coral-xyz/anchor-book that referenced this pull request Mar 21, 2022
Otter-0x4ka5h pushed a commit to Otter-0x4ka5h/anchor that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

avm: make avm use return error if anchor version is not installed (instead of prompting)

3 participants