Skip to content

Conversation

@paul-schaaf
Copy link
Contributor

No description provided.

@paul-schaaf paul-schaaf force-pushed the multiple-test-suites-with-configs branch from fb1416f to d8a6d06 Compare March 25, 2022 01:37
@paul-schaaf
Copy link
Contributor Author

@armaniferrante this is ready for review but a test in the CI is falling and I havent found the reason yet. Im not able to reproduce it locally. if it fails on your machine that might give us a lead

@paul-schaaf
Copy link
Contributor Author

logging the ledger logs in the ci helped. we have to update to Solana 1.9 to get access to the --account flag in the ci

@paul-schaaf
Copy link
Contributor Author

blocked by #1653

@paul-schaaf paul-schaaf marked this pull request as ready for review March 27, 2022 16:54
Copy link
Contributor

@tomlinton tomlinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and it worked great. Some minor nits would be renaming forth-suite to fourth-suite and consistent casing on the ts filenames. No impact on the functionality tough.

Copy link
Contributor

@armaniferrante armaniferrante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits. ship it.

Copy link

@polarisiota polarisiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants