cli: set I/O stream to Stdio:null if the given solana_version is already installed

[simplysabir]

Description :

• Added Conditional with currently installed version of solana
• It's related to this issue Show installation progress when solana_version is not installed in CLI #2724

[vercel]

@simplysabir is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

[acheroncrypto]

Thank you for your interest in contributing to Anchor!

This implementation doesn't currently solve the issue described in #2724 because the installation progress is still not visible.

[simplysabir]

Thank you for your interest in contributing to Anchor!

This implementation doesn't currently solve the issue described in #2724 because the installation progress is still not visible.

So i Should do this right?

• If the Solana version is already installed (is_solana_version_installed returns true), it will set the standard I/O streams to null during the installation process.
• If the Solana version is not installed, it will execute the installation command without redirecting the standard I/O streams, allowing to see the installation progress.

am i right on this approach?

[acheroncrypto]

am i right on this approach?

Yes, the I/O behavior should change based on whether the version is already installed.

[simplysabir]

am i right on this approach?

Yes, the I/O behavior should change based on whether the version is already installed.

Added another implementation kindly have a look.

[acheroncrypto]

These comments don't add any context to what's being done, please remove them.

[simplysabir]

@acheroncrypto Removed comments and updated the is_solana_version_installed function to be

fn is_solana_version_installed(version: &str) -> Result<bool> {
    let output = std::process::Command::new("ls")
        .arg("-l")
        .arg("~/.local/share/solana/install/releases")
        .output()?;

    if output.status.success() {
        let output_versions = std::str::from_utf8(&output.stdout)?;
        Ok(output_versions.lines().any(|line| line.contains(version)))
    } else {
        Err(anyhow!("Failed to list Solana installed versions"))
    }
}

[acheroncrypto]

Looks great but I've changed ls command to solana-install list to make it simpler and OS agnostic.

Thank you for contributing!