fix(ts): correctly construct field layout for type aliases #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halfbakedsneed is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
halfbakedsneed
force-pushed
the
fix/field-layout-type-aliased-args
branch
from
5331622 to
a54908a
Compare
halfbakedsneed
force-pushed
the
fix/field-layout-type-aliased-args
branch
from
a54908a to
8601306
Compare
acheroncrypto
approved these changes
Feb 19, 2024
Collaborator
acheroncrypto
left a comment
acheroncrypto
left a comment
There was a problem hiding this comment.
Thanks for the concise explanation and fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Field layouts for type aliased instruction arguments were being constructed using the type alias name as the field name instead of the instruction name (#2820).
Summary of changes
Alters
IdlCodersuch that it now uses the field (ix) name instead of the type alias name when constructing field layouts.Fixes
Fixes #2820