Updated Intro to solana mobile #478
Conversation
|
hello @mikemaccana , still looking forward to your review of my superteam submission |
|
Hey @dvrvsimi ! I'm checking this out shortly and will come back to you! |
alright @mikemaccana |
|
hello @mikemaccana and @nickfrosty , i just resolved conflicts, still waiting for your review🙏🏾 |
There was a problem hiding this comment.
Hi @dvrvsimi! This is one of the better PRs I've seen for this chapter, you have a good chance of winning. There's lots of small fixes here but you should be able to do them quickly, you will also need to make a PR update the Unboxed repo - while you're at it, please include some new screenshots!
I'm mikemaccana on either Twiteer or Telegram if you want to communicate faster.
| Once you've completed this, you can check your solution against the solution | ||
| code available on the | ||
| [solution branch](https://github.com/Unboxed-Software/solana-react-native-counter/tree/solution). |
There was a problem hiding this comment.
You'll need to update this repo to reflect your code changes as mentioned in the Superteam Bounty. After it's done let me know and I'll move it to solana-developers.
There was a problem hiding this comment.
opened a PR here: Unboxed-Software/solana-react-native-counter#2
please let me know if there's anything that needs changes
| code available on the | ||
| [solution branch](https://github.com/Unboxed-Software/solana-react-native-counter/tree/solution). | ||
| If you’ve successfully completed the lab, push your code to GitHub and share | ||
| your feedback on this lesson through this |
There was a problem hiding this comment.
Keep the callout please.
There was a problem hiding this comment.
i have included it but i noticed that <Callout> doesn't allow the links to render properly (safe to say it won't enable markdown syntax, it might be an issue with my text editor)
removed redundant comment Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
grammatical fix Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
changed "units" to "lessons" for uniformity Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
improved structure for easier readability Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
removed quoted and improved tone Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
changed grammar structure to improve clarity Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
…larity, used further contribution guidelines
…developer-content into intro_to_solana_mobile
|
hello mike, that's strange
I can't access my submission link because the status on the site has been
changed to "Submission in Review". However, here is a link to my superteam
profile: https://earn.superteam.fun/t/dvrvsimi/
…On Mon, Oct 7, 2024 at 3:49 AM Mike MacCana ***@***.***> wrote:
@dvrvsimi <https://github.com/dvrvsimi> What is the URL for your
superteam entry? I can't find anything from dvrvsimi or Akojede Olorundara.
—
Reply to this email directly, view it on GitHub
<#478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZCOAANOL6OYT6FFYMRYZ3LZ2HZFDAVCNFSM6AAAAABODTTGMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVG44DIMBTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* chore: updated lesson summary * improved lesson overview * improved intro to solana mobile * updated use cases * grammar restructure * updating in compliance to contribution guideline * updating in compliance to contribution guide * more descriptive variable names, handled errors, avoided repitition * fixed title * updated conclusion and included useful links * improved setup section, removed unnecesary pragraphs * minor update to ConnectionProvider function * improved some functions in .tsx files, added comments where necessary * improved basic-solana-mobile-connect.png * improved basic-solana-mobile-flow.png * improved basic-solana-mobile-transact.png * fixed content styling * replaced cryprocurrency with blockchain transactions * cryptocurrency to blockchain transactions * cleanup * improved intro to beginner-friendly standard * improved clarity * more restructuring, building a more readable flow, especially for rust beginners * minor fixes, resolved conflict * prettier:fix * prettier:fix * prettier:fix * Update content/courses/mobile/intro-to-solana-mobile.md removed redundant comment Co-authored-by: Mike MacCana <mike.maccana@gmail.com> * Update content/courses/mobile/intro-to-solana-mobile.md grammatical fix Co-authored-by: Mike MacCana <mike.maccana@gmail.com> * Update content/courses/mobile/intro-to-solana-mobile.md changed "units" to "lessons" for uniformity Co-authored-by: Mike MacCana <mike.maccana@gmail.com> * Update content/courses/mobile/intro-to-solana-mobile.md improved structure for easier readability Co-authored-by: Mike MacCana <mike.maccana@gmail.com> * Update content/courses/mobile/intro-to-solana-mobile.md removed quoted and improved tone Co-authored-by: Mike MacCana <mike.maccana@gmail.com> * Update content/courses/mobile/intro-to-solana-mobile.md changed grammar structure to improve clarity Co-authored-by: Mike MacCana <mike.maccana@gmail.com> * requested changes: removed redundant sections, typo fixes, improved clarity, used further contribution guidelines * removed backticks in titles, resolved merge conflicts * fixed broken links * revert changes in rust-acro.md * prettier fix * revert image changes * changed Solana community forum link from discord to stack exchange * added official link to install node * fix formatting * Delete content/courses/program-optimization/developer-content.code-workspace * fix links --------- Co-authored-by: Akojede Olorundara <daraakojede01gmail.com> Co-authored-by: Mike MacCana <mike.maccana@gmail.com>
2 participants
Problem
Summary of Changes
.tsxsections to improve code readabilityFixes #