Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance: Realm authority validation #2787

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Governance: Realm authority validation #2787

merged 5 commits into from
Jan 24, 2022

Conversation

SebastianBor
Copy link
Contributor

@SebastianBor SebastianBor commented Jan 24, 2022

Summary

When a realm is created its realm_authority is initially set to some wallet (usually the realm's creator).
After governances are added to the realm then one of them is elected as the realm_authority

The purpose of this change it to prevent footgun scenario where the authority could be set to none existing or wrong account

@SebastianBor SebastianBor changed the title Governance: Strict realm authority Governance: Realm authority validation Jan 24, 2022
@SebastianBor SebastianBor marked this pull request as ready for review January 24, 2022 16:52
joncinque
joncinque previously approved these changes Jan 24, 2022
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing that should prevent this from going forward, just a couple of nits / suggestions

governance/program/src/instruction.rs Show resolved Hide resolved
governance/program/src/instruction.rs Show resolved Hide resolved
governance/program/src/state/legacy.rs Outdated Show resolved Hide resolved
governance/program/src/state/realm.rs Outdated Show resolved Hide resolved
@mergify mergify bot dismissed joncinque’s stale review January 24, 2022 17:42

Pull request has been modified.

SebastianBor and others added 2 commits January 24, 2022 19:14
Co-authored-by: Jon Cinque <jon.cinque@gmail.com>
Co-authored-by: Jon Cinque <jon.cinque@gmail.com>
@SebastianBor SebastianBor merged commit bc00009 into solana-labs:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants