Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stake-pool-py: Clean up dependencies #3412

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

joncinque
Copy link
Contributor

Problem

We want to separate the dependencies to avoid bundling too much in the stake pool python package.

Solution

Split up the deps between requirements.txt and optional-requirements.txt. @c3pko You can use everything in requirements.txt as the dependencies, and everything in optional-requirements.txt in `optional-dependencies. After this is merged, you can rebase your PR, and remove both of these requirements files.

@joncinque joncinque requested a review from c3pko August 2, 2022 18:59
@joncinque
Copy link
Contributor Author

The stake pool python tests passed, and that's what matters most -- merging on red!

@joncinque joncinque merged commit 8f75f59 into solana-labs:master Aug 2, 2022
@joncinque joncinque deleted the spdep branch August 2, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant