Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wallet cli errors #5437

Closed
mvines opened this issue Aug 6, 2019 · 6 comments

Comments

@mvines
Copy link
Member

commented Aug 6, 2019

Some of the wallet cli errors can be pretty unhelpful if you are unfamiliar with the system. These instances come to mind:

  • create-vote-account from a keypair with insufficient lamports to pay the fee. We can check the payer account balance before hand and cleanly error. This should apply to all wallet transactions
  • create-vote-account for a vote account that already exists returns an unhelpful program error.
  • solana-wallet create-vote-account "$IDENTITY_PUBKEY" "$VOTE_PUBKEY" 1 returns an unhelpful error
  • Always report the RPC end point the wallet is about to contact (to make it obvious when --url is not supplied that the user may be talking to the wrong cluster. Also cc: #5436)
  • Be smart about detecting duplicate keys. solana-wallet create-vote-account "$IDENTITY_PUBKEY" "$IDENTITY_PUBKEY" 1 should fail locally before sending a transaction

@mvines mvines added this to the Mavericks v0.18.0 milestone Aug 6, 2019

@mvines mvines added this to To do in TdS Stage 0 via automation Aug 6, 2019

@CriesofCarrots CriesofCarrots self-assigned this Aug 7, 2019

@mvines mvines moved this from To do to In progress in TdS Stage 0 Aug 9, 2019

@CriesofCarrots

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

@mvines , can you point me at the source of bullet 3? I am trying to determine whether it is the same issue as either bullet 2 or "failed transaction due to insufficient funds", or if it's something different...?

@CriesofCarrots

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Bullet 1: Done in #5474

@mvines

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

@mvines , can you point me at the source of bullet 3? I am trying to determine whether it is the same issue as either bullet 2 or "failed transaction due to insufficient funds", or if it's something different...?

This bullet was about running solana-wallet create-vote-account with the vote and identity pubkeys swapped

@CriesofCarrots

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

Bullet 4: Done #5482

@mvines mvines moved this from In progress to Non-blocking in TdS Stage 0 Aug 10, 2019

@CriesofCarrots

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Bullet 2: Done in #5494

@CriesofCarrots

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

Bullet 5: Done in #5497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.