Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: allow the user to supply a keypair .json file in addition to pubkey for some commands #5439

Closed
mvines opened this issue Aug 6, 2019 · 0 comments

Comments

@mvines
Copy link
Member

commented Aug 6, 2019

show-stake-account, show-vote-account, and delegate-stake (probably others too) make the use figure the public key from a keypair json file and supply that public key on the wallet command-line. This is a little annoying/painful. eg:

$ VOTE_PUBKEY=$(solana-keygen pubkey ~/validator-vote-keypair.json)
$ IDENTITY_PUBKEY=$(solana-keygen pubkey ~/validator-keypair.json)
$ solana-wallet create-vote-account "$VOTE_PUBKEY" "$IDENTITY_PUBKEY" 1

🤕

Let's also permit this form:

$ solana-wallet create-vote-account ~/validator-vote-keypair.json ~/validator-keypair.json 1

as a convenience to users who don't mind giving the full keypair, even though only the public key is required.

@mvines mvines added this to the Mavericks v0.18.0 milestone Aug 6, 2019

@mvines mvines added this to To do in TdS Stage 0 via automation Aug 6, 2019

@CriesofCarrots CriesofCarrots self-assigned this Aug 7, 2019

TdS Stage 0 automation moved this from To do to Done Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.