Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator: Filter out delinquent validators when looking for a snapshot #8292

Closed
mvines opened this issue Feb 14, 2020 · 3 comments
Closed

validator: Filter out delinquent validators when looking for a snapshot #8292

mvines opened this issue Feb 14, 2020 · 3 comments

Comments

@mvines
Copy link
Member

@mvines mvines commented Feb 14, 2020

When a validator comes up and looks for a snapshot over RPC, it can easily pick a delinquent validator and thus get a very old snapshot.

@mvines mvines added this to the Tofino v0.23.5 milestone Feb 14, 2020
@mvines

This comment has been minimized.

Copy link
Member Author

@mvines mvines commented Feb 14, 2020

This is a little tricky because currently at startup solana-validator has no good point of reference as to what the latest slot should be -- it gets a gossip entrypoint and it figures out an RPC service to use. A delinquent's RPC service may very well say that it's not delinquent! So either there needs to be a trusted RPC service, or a validator needs to canvass multiple RPC services (which seems not nice from a network load perspective)

@mvines

This comment has been minimized.

Copy link
Member Author

@mvines mvines commented Feb 14, 2020

The delinquents that are off on their own forks making no progress will not have their max confirmed slot increasing, so that might be a decent first start. That is, after selecting an RPC service, watch it for a couple seconds to see if it's making progress before committing to use it

@mvines

This comment has been minimized.

Copy link
Member Author

@mvines mvines commented Feb 14, 2020

Gossiping the latest snapshot root seems like an option

@mvines mvines modified the milestones: Tofino v0.23.5, Tofino v0.23.6 Feb 15, 2020
@mvines mvines closed this in #8361 Feb 21, 2020
@mvines mvines added this to Needs triage in TdS Potholes via automation Feb 24, 2020
@mvines mvines moved this from Needs triage to Closed in TdS Potholes Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
TdS Potholes
  
Closed
1 participant
You can’t perform that action at this time.