Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI exposes implementation detail "lamports" #8296

Closed
garious opened this issue Feb 15, 2020 · 2 comments
Closed

CLI exposes implementation detail "lamports" #8296

garious opened this issue Feb 15, 2020 · 2 comments
Assignees
Milestone

Comments

@garious
Copy link
Member

@garious garious commented Feb 15, 2020

Problem

The CLI was originally written using all lamports, and then later, we added support for SOL. Now there's this fundamentally unnecessary option disambiguate between lamports and SOL, which is done by adding an argument with the text "lamports" or "SOL". That optional argument adds awkward edge cases, like, what happens if "SOL" is valid input for the next argument? Also, by retaining support for "lamports", we need to document it. Why brand 2 terms when 1 will suffice?

Proposed Solution

Remove support for "lamports" and remove support for specifying units.

cc: @CriesofCarrots

@mvines

This comment has been minimized.

Copy link
Member

@mvines mvines commented Feb 15, 2020

👍 Especially with base10 lamports now, this is much easier!
solana pay 0.000000001 works just as well as solana pay 1 lamport

@CriesofCarrots

This comment has been minimized.

Copy link
Contributor

@CriesofCarrots CriesofCarrots commented Feb 15, 2020

I did run into some errors with #8291 in release build, so I'm going to move forward fixing this since it will resolve that issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.