Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump borsh from 0.9.0 to 0.9.1 #18664

Merged
merged 3 commits into from Jul 15, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 14, 2021

Bumps borsh from 0.9.0 to 0.9.1.

Release notes

Sourced from borsh's releases.

v0.9.1

  • Eliminated unsafe code from both ser and de of u8 (#26)
  • Implemented ser/de for reference count types (#27)
  • Added serialization helpers to improve api ergonomics (#34)
  • Implemented schema for arrays and fix box bounds (#36)
  • Implemented (de)ser for PhantomData (#37)
  • Implemented const-generics under feature (#38)
  • Added an example of direct BorshSerialize::serialize usage with vector and slice buffers (#29)
Changelog

Sourced from borsh's changelog.

0.9.1

  • Eliminated unsafe code from both ser and de of u8 (#26)
  • Implemented ser/de for reference count types (#27)
  • Added serialization helpers to improve api ergonomics (#34)
  • Implemented schema for arrays and fix box bounds (#36)
  • Implemented (de)ser for PhantomData (#37)
  • Implemented const-generics under feature (#38)
  • Added an example of direct BorshSerialize::serialize usage with vector and slice buffers (#29)
Commits
  • 3cf02fb docs: Added 0.9.1 changelog
  • dd3f28c Release 0.9.1
  • 88459fc feat: implement const-generics under feature (#38)
  • fdf4f5f feat: impl (de)ser for PhantomData (#37)
  • 63920c6 feat: implement schema for arrays and fix box bounds (#36)
  • 134a797 Add serialization helpers to improve api ergonomics (#34)
  • 4cc01a7 docs: Added an example of direct BorshSerialize::serialize usage with vector ...
  • eff33a6 Implement ser/de for reference count types (#27)
  • 3223286 feat!: Eliminate unsafe code from both ser and de of u8 (#26)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [borsh](https://github.com/near/borsh-rs) from 0.9.0 to 0.9.1.
- [Release notes](https://github.com/near/borsh-rs/releases)
- [Changelog](https://github.com/near/borsh-rs/blob/master/CHANGELOG.md)
- [Commits](near/borsh-rs@v0.9.0...v0.9.1)

---
updated-dependencies:
- dependency-name: borsh
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies rust Pull requests that update Rust code labels Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #18664 (75ce30f) into master (74b29c0) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #18664     +/-   ##
=========================================
- Coverage    82.7%    82.7%   -0.1%     
=========================================
  Files         436      436             
  Lines      123485   123490      +5     
=========================================
- Hits       102192   102157     -35     
- Misses      21293    21333     +40     

@CriesofCarrots
Copy link
Contributor

@joncinque , do you see any potential issues with this borsh bump in master sdk? SPL downstream-projects build looks fine, but would love a sanity check.

@joncinque
Copy link
Contributor

Seems like it's reasonable, especially if the downstream build succeeds. Doesn't seem like there are any breaking changes according to the release notes. Is there a reason for only bumping this up in banks-client and not everywhere all at once, and not bumping up borsh-derive at the same time?

@CriesofCarrots
Copy link
Contributor

Is there a reason for only bumping this up in banks-client and not everywhere all at once, and not bumping up borsh-derive at the same time?

Ha, the reason is that dependabot is fairly short-sighted, and I didn't ponder the changeset enough. Good idea, I'll expand!

@joncinque
Copy link
Contributor

I was really surprised it only picked up that one change, and of all places, banks-client seems like one of the least intuitive ones... unless it just goes alphabetically and picks the first package?

@CriesofCarrots CriesofCarrots merged commit 2186843 into master Jul 15, 2021
@dependabot dependabot bot deleted the dependabot/cargo/borsh-0.9.1 branch July 15, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants