Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make find_program_address client example runnable #23492

Merged
merged 1 commit into from Mar 24, 2022
Merged

Make find_program_address client example runnable #23492

merged 1 commit into from Mar 24, 2022

Conversation

brson
Copy link
Contributor

@brson brson commented Mar 4, 2022

This uses solana_program::example_mocks to make the Pubkey::find_program_address client example testable.

@mergify mergify bot added the community Community contribution label Mar 4, 2022
@mergify mergify bot requested a review from a team March 4, 2022 23:21
@brson
Copy link
Contributor Author

brson commented Mar 6, 2022

CI looks like a timeout.

CriesofCarrots
CriesofCarrots approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #23492 (b86d0b0) into master (d2b23da) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23492   +/-   ##
=======================================
  Coverage    81.4%    81.4%           
=======================================
  Files         574      574           
  Lines      156511   156511           
=======================================
+ Hits       127524   127549   +25     
+ Misses      28987    28962   -25

@CriesofCarrots CriesofCarrots merged commit 6428602 into solana-labs:master Mar 24, 2022
mergify bot pushed a commit that referenced this pull request Mar 24, 2022
@brson
Make find_program_address client example runnable (#23492)
a164dc5 
(cherry picked from commit 6428602)
@mergify mergify bot mentioned this pull request Mar 24, 2022
Merged
mergify bot added a commit that referenced this pull request Mar 24, 2022
@mergify @brson
Make find_program_address client example runnable (#23492) (#23901)
1b930a1 
(cherry picked from commit 6428602)

Co-authored-by: Brian Anderson <andersrb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CriesofCarrots CriesofCarrots CriesofCarrots approved these changes

Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brson @CriesofCarrots