This repository was archived by the owner on Jan 22, 2025. It is now read-only.
KvStore - A data-store to support BlockTree - #2897
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2897 +/- ##
========================================
- Coverage 81.5% 78% -3.5%
========================================
Files 129 131 +2
Lines 19578 20476 +898
========================================
+ Hits 15958 15989 +31
- Misses 3620 4487 +867 |
Contributor
|
Hey @MarkJr94, anything you can do to get us off RocksDB sooner than later would be greatly appreciated! |
Contributor
|
No merge commits please! Just rebase! |
Member
|
Can you rebase and squash this pr, it seems like it’s pulling in a lot of commits that are in master. |
Contributor
Author
|
@aeyakovenko yes before i change this from draft status today I'll fix up the commit history. worst case i'll just force-push from a cleaner branch where i have copied over changes manually, which would be fairly easy to do since most changes don't affect anything els.e |
garious
reviewed
Mar 11, 2019
Contributor
|
yikes, merging while CI is still running. 📿 |
Contributor
|
NBD, he only added a cfg() macro that only affected a configuration uncovered by CI. |
Contributor
|
Maybe :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is largely a WIP PR for work on this issue #2566
Everything about
BlobStoreis out-dated, especially due toBlockTree.A fuller design description will be posted as things progress. For now please see the tracking issue.
Problem
rocks
Summary of Changes
simple key-value store to persist ledger data
Fixes #2566