Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename solana-runtime to sealevel #6239

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@garious
Copy link
Member

garious commented Oct 4, 2019

Problem

Solana's runtime development is not benefiting from collaboration with other layer 1 solutions. Currently, it would be as awkward for another project to embed solana_runtime as it was for Solana to embed Libra's Move (fork and hack it). It's technically possible, but we don't want to discourage collaboration or encourage forks.

Summary of Changes

Rename solana_runtime to sealevel. This PR doesn't also rename solana_sdk, as described in the issue. Looks like that crate should first be split into two (one for programs, one for program tests).

This can go in as-is, but there's still a lot more work before this is suitable for embedding in other layer 1s. We may, for example, want to decouple sealevel from the Vote and Storage programs.

Fixes #5486

@garious garious force-pushed the garious:sealevel branch from 6e4ade1 to 74d523b Oct 4, 2019
@mvines

This comment has been minimized.

Copy link
Member

mvines commented Oct 4, 2019

The problem description doesn't describe a problem

@garious

This comment has been minimized.

Copy link
Member Author

garious commented Oct 4, 2019

better?

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #6239 into master will decrease coverage by 0.8%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #6239     +/-   ##
========================================
- Coverage    77.5%   76.6%   -0.9%     
========================================
  Files         210     210             
  Lines       40036   40491    +455     
========================================
+ Hits        31037   31044      +7     
- Misses       8999    9447    +448
runtime/src/lib.rs Outdated Show resolved Hide resolved
@garious garious requested a review from mvines Oct 4, 2019
@garious garious force-pushed the garious:sealevel branch from bf9613e to e334b95 Oct 4, 2019
@mvines
mvines approved these changes Oct 4, 2019
Copy link
Member

mvines left a comment

Might want to manually publish to https://crates.io/crates/sealevel so somebody else doesn't squat on that name before 0.20.0 ships at the end of the month :)

@garious garious added the automerge label Oct 4, 2019
@solana-grimes solana-grimes merged commit 2e92143 into solana-labs:master Oct 4, 2019
11 checks passed
11 checks passed
Summary 1 rule matches and 7 potential rules
Details
buildkite/solana Build #12679 passed (42 minutes, 12 seconds)
Details
buildkite/solana/bench Passed (13 minutes, 10 seconds)
Details
buildkite/solana/checks Passed (1 minute, 54 seconds)
Details
buildkite/solana/coverage Passed (15 minutes, 35 seconds)
Details
buildkite/solana/local-cluster Passed (13 minutes, 6 seconds)
Details
buildkite/solana/pipeline-upload Passed (2 seconds)
Details
buildkite/solana/shellcheck Passed (27 seconds)
Details
buildkite/solana/stable Passed (23 minutes, 8 seconds)
Details
buildkite/solana/stable-perf Passed (9 minutes, 11 seconds)
Details
ci-gate Pull Request accepted for CI pipeline
garious added a commit that referenced this pull request Oct 5, 2019
This reverts commit 2e92143.
garious added a commit that referenced this pull request Oct 5, 2019
This reverts commit 2e92143.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.