Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solana-ledger crate #6415

Merged
merged 6 commits into from Oct 18, 2019

Conversation

@garious
Copy link
Member

garious commented Oct 17, 2019

Problem

core is a big mess and a pain to work in. Also, some crates like genesis and ledger-tool depend on core for nothing more than blocktree and its dependencies.

Summary of Changes

  • Move Blocktree and its dependencies to a new crate, solana_ledger. In core, cargo test --libs takes ~3 minutes. In ledger, it takes 14 seconds.
  • genesis no longer depends on core, only ledger
  • ledger-tool still depends on core for blocktree_processor
  • Leave blocktree_processor in core for now, since it introduces another set of circular dependencies.
  • Leave RootedSlotIterator in core, since its test depends on blocktree_processor.
  • Moved some functions out of their tests module, because rustc isn't able to find code in #[cfg(test)] in other crates, not sure why.
  • Moved perf-libs to ledger, but perhaps that should be its own crate?
@garious garious force-pushed the garious:solana-ledger branch 7 times, most recently from 9e5fe29 to 6f88b1d Oct 17, 2019
@garious garious added the CI label Oct 17, 2019
@solana-grimes solana-grimes removed the CI label Oct 17, 2019
@garious garious force-pushed the garious:solana-ledger branch from 6f88b1d to a2935d3 Oct 17, 2019
@garious garious added the CI label Oct 18, 2019
@garious garious force-pushed the garious:solana-ledger branch from d1c50c4 to 40f7b12 Oct 18, 2019
@solana-grimes solana-grimes removed the CI label Oct 18, 2019
@garious garious force-pushed the garious:solana-ledger branch 2 times, most recently from 5b3d31a to 62a8728 Oct 18, 2019
@garious garious marked this pull request as ready for review Oct 18, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #6415 into master will decrease coverage by 2%.
The diff coverage is 84%.

@@           Coverage Diff            @@
##           master   #6415     +/-   ##
========================================
- Coverage    79.8%   77.8%   -2.1%     
========================================
  Files         216     217      +1     
  Lines       41243   42342   +1099     
========================================
+ Hits        32941   32956     +15     
- Misses       8302    9386   +1084
@garious garious force-pushed the garious:solana-ledger branch from 62a8728 to 31ee2db Oct 18, 2019
@garious

This comment has been minimized.

Copy link
Member Author

garious commented Oct 18, 2019

@mvines, @rob-solana, care to review? A large diff, but I think the "Summary of Changes" in the PR description captures everything important.

@mvines

This comment has been minimized.

Copy link
Member

mvines commented Oct 18, 2019

Love to see core getting smaller, lgtm!

@garious garious force-pushed the garious:solana-ledger branch from 31ee2db to 41ce1a7 Oct 18, 2019
garious added 6 commits Oct 17, 2019
@garious garious force-pushed the garious:solana-ledger branch from 41ce1a7 to 933d3ab Oct 18, 2019
@garious garious added the automerge label Oct 18, 2019
@garious

This comment has been minimized.

Copy link
Member Author

garious commented Oct 18, 2019

Need to smash this in before I need to rebase again. Post-merge review welcome. Also, more to come soon, splitting snapshot_packager_service so that blocktree_processor can join the party.

@solana-grimes solana-grimes merged commit 5468be2 into solana-labs:master Oct 18, 2019
11 checks passed
11 checks passed
Summary 1 rule matches and 7 potential rules
Details
buildkite/solana Build #13316 passed (53 minutes, 27 seconds)
Details
buildkite/solana/bench Passed (14 minutes, 44 seconds)
Details
buildkite/solana/checks Passed (4 minutes, 23 seconds)
Details
buildkite/solana/coverage Passed (33 minutes, 57 seconds)
Details
buildkite/solana/local-cluster Passed (22 minutes, 14 seconds)
Details
buildkite/solana/pipeline-upload Passed (10 seconds)
Details
buildkite/solana/shellcheck Passed (35 seconds)
Details
buildkite/solana/stable Passed (27 minutes, 17 seconds)
Details
buildkite/solana/stable-perf Passed (17 minutes, 56 seconds)
Details
ci-gate Pull Request accepted for CI pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.