Add ping cli option to use CommitmentLevel::Max #6775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not in love with the arg text |
mvines
reviewed
Nov 6, 2019
mvines
previously approved these changes
Nov 6, 2019
CriesofCarrots
force-pushed
the
ping-arg
branch
from
f4d0c38
to
7ec2704
Compare
CriesofCarrots
added
the
automerge
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Default rpc commitment is now set to CommitmentLevel::Max. In order to prevent slow-down of
solana pingtransactions, the default was overridden. However, it would be nice to use ping to see how long it takes for a transaction confirmation to reach root.Summary of Changes
max-commitment. If present, ping requests rooted transaction confirmations (CommitmentLevel::Max). If absent, ping continues to request recent transaction confirmations (CommitmentLevel::Recent)