Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive the parallel bank client #6903

Merged
merged 1 commit into from Nov 12, 2019
Merged

Conversation

@garious
Copy link
Member

garious commented Nov 12, 2019

Problem

A validator processes transactions in parallel. BankClient (used by unit tests) used to process transactions in parallel too back in v0.16, but was changed to process them sequentially to improve CI stability.

Summary of Changes

Resurrect the parallelism and see if it exposes any real bugs.

cc: @rob-solana

@garious garious closed this Nov 12, 2019
@garious garious reopened this Nov 12, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4bc8fd3). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #6903   +/-   ##
========================================
  Coverage          ?   79.8%           
========================================
  Files             ?     219           
  Lines             ?   42226           
  Branches          ?       0           
========================================
  Hits              ?   33724           
  Misses            ?    8502           
  Partials          ?       0
@garious garious marked this pull request as ready for review Nov 12, 2019
@garious garious merged commit 986e9e2 into solana-labs:master Nov 12, 2019
12 checks passed
12 checks passed
Summary 1 rule matches and 7 potential rules
Details
buildkite/solana Build #14825 passed (26 minutes, 18 seconds)
Details
buildkite/solana/bench Passed (18 minutes, 4 seconds)
Details
buildkite/solana/checks Passed (1 minute, 52 seconds)
Details
buildkite/solana/coverage Passed (12 minutes, 44 seconds)
Details
buildkite/solana/local-cluster Passed (13 minutes, 27 seconds)
Details
buildkite/solana/move Passed (8 minutes, 57 seconds)
Details
buildkite/solana/pipeline-upload Passed (3 seconds)
Details
buildkite/solana/shellcheck Passed (29 seconds)
Details
buildkite/solana/stable Passed (24 minutes, 16 seconds)
Details
buildkite/solana/stable-perf Passed (8 minutes, 16 seconds)
Details
ci-gate Pull Request accepted for CI pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.