Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana-keygen: Support pubkey recovery directly from seed phrase #7149

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@jstarry
Copy link
Member

jstarry commented Nov 26, 2019

Problem

No way to output the pubkey from a seed phrase without writing the keypair file

Summary of Changes

  • Support ASK keyword as infile arg to trigger seed phrase prompt
  • Add --skip-seed-phrase-validation flag to pubkey command
[pubkey recovery] seed phrase: 
[pubkey recovery] If this seed phrase has an associated passphrase, enter it now. Otherwise, press ENTER to continue: 
FL1YVL3zzZ3V7BWaBPVrwjCXerNoudceRoN9sL6SoVPi

Fixes #7148

@jstarry jstarry requested a review from t-nelson Nov 26, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #7149 into master will increase coverage by <.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #7149     +/-   ##
========================================
+ Coverage    79.2%   79.3%   +<.1%     
========================================
  Files         230     230             
  Lines       45119   45119             
========================================
+ Hits        35779   35780      +1     
+ Misses       9340    9339      -1
@jstarry jstarry merged commit 4fe1716 into solana-labs:master Nov 26, 2019
12 checks passed
12 checks passed
Summary 2 rules match and 2 potential rules
Details
buildkite/solana Build #15699 passed (30 minutes, 47 seconds)
Details
buildkite/solana/bench Passed (11 minutes, 37 seconds)
Details
buildkite/solana/checks Passed (1 minute, 26 seconds)
Details
buildkite/solana/coverage Passed (10 minutes, 49 seconds)
Details
buildkite/solana/local-cluster Passed (14 minutes, 17 seconds)
Details
buildkite/solana/move Passed (11 seconds)
Details
buildkite/solana/pipeline-upload Passed (3 seconds)
Details
buildkite/solana/shellcheck Passed (29 seconds)
Details
buildkite/solana/stable Passed (29 minutes, 3 seconds)
Details
buildkite/solana/stable-perf Passed (9 minutes, 32 seconds)
Details
ci-gate Pull Request accepted for CI pipeline
@mvines mvines added the v0.21 label Nov 26, 2019
@mvines

This comment has been minimized.

Copy link
Member

mvines commented Nov 26, 2019

This was fixing a 0.21 issue so I added the v0.21 label to get the backport moving

mergify bot pushed a commit that referenced this pull request Nov 26, 2019
(cherry picked from commit 4fe1716)
solana-grimes added a commit that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.