validator: Add --wait-for-super-majority to facilitate asynchronous cluster restarts #7701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-solana
previously approved these changes
Jan 7, 2020
mergify
bot
dismissed
sagar-solana’s stale review
Pull request has been modified.
garious
reviewed
Jan 7, 2020
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #7701 +/- ##
========================================
- Coverage 81.7% 81.7% -0.1%
========================================
Files 243 243
Lines 50497 50524 +27
========================================
+ Hits 41285 41289 +4
- Misses 9212 9235 +23 |
sakridge
pushed a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
…luster restarts (bp solana-labs#7701) (solana-labs#7704) automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restarting a cluster from a snapshot currently requires a high-level of coordination between all the staked nodes.
solana-validator --wait-for-super-majority ...alleviates this issue by instructing the validator to remain parked on gossip until it sees > 66% of the stake on gossip as well.