Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Hack to skip cleanup_dead_slots upon snapshot load #8561
A validator started from snapshot may create bad snapshots, which cause bank hash mismatch error when consumed by other validators. This is because the validator internally removes too much AccountsStorage and bad snapshots don't include some necessary ones anymore.
Detail of problem
After #8148, the callee started to remove actually. But things don't break immediately. Snapshots load successfully. And validator just works.
Summary of Changes
Until #8337 lands, just disable erroneous too eager removing behavior as an ugly hack...
Backport only to v1.0 because v0.23 was branched before #8148.
This PR is first worked on the