Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use ? instead of unwrap() #870
Regarding https://solana-ci-gate.herokuapp.com/buildkite_public_log?https://buildkite.com/solana-labs/solana/builds/2088, I'd like to know rustc's versions on the CI hosts.
referenced this pull request
Aug 6, 2018
@aeyakovenko, what do you think about this? My feeling is that when you're using either
@aeyakovenko, I prefer this notation for a few reasons:
- More readable
- Debugging those Errors might encourage us to create more descriptive Error types.
- Test code could be copied into prod code and vice versa. It'll be easier to create tests from existing code and easier to bootstrap code from samples in test.
A strong +1 from me.