Normalize generation for reproducible builds #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmdjones
requested changes
May 27, 2022
While working on reproducible builds for openSUSE, I found that our package varied even when building in clean VMs with as little non-determinism as possible. This was because of +++ solanum-0~ch560/ircd/version.c.last @@ -25,7 +25,7 @@ #include "serno.h" #include "stdinc.h" -const char *generation = "6"; +const char *generation = "5"; const char *creation = "1653004800"; const char *ircd_version = PATCHLEVEL; const char *serno = SERNO;
aaronmdjones
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
While working on reproducible builds for openSUSE, I found that
our
solanumpackage varied even when building in clean VMswith as little non-determinism as possible.
This was because of variations in the
generationvalue in version.c